325 lines
12 KiB
Diff
325 lines
12 KiB
Diff
|
From mboxrd@z Thu Jan 1 00:00:00 1970
|
||
|
Return-Path: <linux-kernel-owner@kernel.org>
|
||
|
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
|
||
|
aws-us-west-2-korg-lkml-1.web.codeaurora.org
|
||
|
X-Spam-Level:
|
||
|
X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED,
|
||
|
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
|
||
|
INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
|
||
|
USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no
|
||
|
version=3.4.0
|
||
|
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
|
||
|
by smtp.lore.kernel.org (Postfix) with ESMTP id 51FFEC43460
|
||
|
for <linux-kernel@archiver.kernel.org>; Tue, 13 Apr 2021 06:57:09 +0000 (UTC)
|
||
|
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
|
||
|
by mail.kernel.org (Postfix) with ESMTP id 379F261278
|
||
|
for <linux-kernel@archiver.kernel.org>; Tue, 13 Apr 2021 06:57:09 +0000 (UTC)
|
||
|
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
|
||
|
id S1345127AbhDMG5Z (ORCPT
|
||
|
<rfc822;linux-kernel@archiver.kernel.org>);
|
||
|
Tue, 13 Apr 2021 02:57:25 -0400
|
||
|
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44184 "EHLO
|
||
|
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
|
||
|
with ESMTP id S242333AbhDMG5L (ORCPT
|
||
|
<rfc822;linux-kernel@vger.kernel.org>);
|
||
|
Tue, 13 Apr 2021 02:57:11 -0400
|
||
|
Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a])
|
||
|
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5CAAC06138C
|
||
|
for <linux-kernel@vger.kernel.org>; Mon, 12 Apr 2021 23:56:51 -0700 (PDT)
|
||
|
Received: by mail-qk1-x74a.google.com with SMTP id g62so10544674qkf.18
|
||
|
for <linux-kernel@vger.kernel.org>; Mon, 12 Apr 2021 23:56:51 -0700 (PDT)
|
||
|
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
||
|
d=google.com; s=20161025;
|
||
|
h=date:in-reply-to:message-id:mime-version:references:subject:from:to
|
||
|
:cc;
|
||
|
bh=1g9DmXJ6S7uvtuGOH48osWaF0/2fGGaQ6ChmAYKTm4o=;
|
||
|
b=VX7vOS1iaX+Hrwo31qklSok4an751KXHjlIezhTcoCSLXRV871k6PBsw+EibR4qWwF
|
||
|
i7kN3+4V671SYh9T69KvNxd786HKo+6WHv6Cd77TeqTfMbKijle6EBM4m+gl3DmNgnt0
|
||
|
ZA8WH1LPEZfGwn3JGivnRSoUPFkulI9NBk9pGJpe7wwngua0FZfbXjlpD6td2UZKxBbD
|
||
|
sm8Xc+HrppZn5mA4exh2/iFeR515mlnGTrbTx70pum7Y/iYPYQ2/HgcjccRGsGWUBLbF
|
||
|
bSOTnALSUrqOctmdDO2fO0EzfSnndPfVgKwv5QWLNUcXAi3ZlYRs7lyuvShH4lnaJxFe
|
||
|
LTUA==
|
||
|
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
|
||
|
d=1e100.net; s=20161025;
|
||
|
h=x-gm-message-state:date:in-reply-to:message-id:mime-version
|
||
|
:references:subject:from:to:cc;
|
||
|
bh=1g9DmXJ6S7uvtuGOH48osWaF0/2fGGaQ6ChmAYKTm4o=;
|
||
|
b=oh0TJS5Iv72EGLBpsE6HR3bE5cZX3J2uuz3z3TwZZpsfqvBQ4F+ZjeXnT9ZM8znSwl
|
||
|
DwO2yHU9V2acH3+Fw0txUASuMMXsp1h+eHsdlfoqbA5zx2G/8OJbldp/rudOwBO+wc4D
|
||
|
Wu7IiJYBc9jidKDE7Rputac3XOWXhSIhHMN1UGb8rIrlefaHD89A6pEKF6H/v6TSV99v
|
||
|
1MEtFUSmceep3K2EmUGX64fyXznC0KPZIkHHX/LcuC8xgYK2Go0LXGglt5x6U6QQ+Yk8
|
||
|
QGNr4pv1ynAg5b5FcA5bQe34gJ4JarQfXZx82+zF84UGh0Hj4hR4I60qEnSwVJBlCNqE
|
||
|
o7DA==
|
||
|
X-Gm-Message-State: AOAM532mqZo9PBRpK7zpxWavyuHSPxCR5uYKAcywst7dl0qA/ZdHQHKq
|
||
|
TyCJ6Kl6g2of6qtWwfJ7m9Y3UH3EDGM=
|
||
|
X-Google-Smtp-Source: ABdhPJwH+ey8nBGqYBlYs+cX0y6B8vZ/ifwsZXXs+V8u1FJGnhfXc1ufux+fOtI1iR9OnRAE6E9FqbhZIZQ=
|
||
|
X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:d02d:cccc:9ebe:9fe9])
|
||
|
(user=yuzhao job=sendgmr) by 2002:a0c:db82:: with SMTP id m2mr21253979qvk.37.1618297010980;
|
||
|
Mon, 12 Apr 2021 23:56:50 -0700 (PDT)
|
||
|
Date: Tue, 13 Apr 2021 00:56:24 -0600
|
||
|
In-Reply-To: <20210413065633.2782273-1-yuzhao@google.com>
|
||
|
Message-Id: <20210413065633.2782273-8-yuzhao@google.com>
|
||
|
Mime-Version: 1.0
|
||
|
References: <20210413065633.2782273-1-yuzhao@google.com>
|
||
|
X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog
|
||
|
Subject: [PATCH v2 07/16] mm/vmscan.c: refactor shrink_node()
|
||
|
From: Yu Zhao <yuzhao@google.com>
|
||
|
To: linux-mm@kvack.org
|
||
|
Cc: Alex Shi <alexs@kernel.org>, Andi Kleen <ak@linux.intel.com>,
|
||
|
Andrew Morton <akpm@linux-foundation.org>,
|
||
|
Benjamin Manes <ben.manes@gmail.com>,
|
||
|
Dave Chinner <david@fromorbit.com>,
|
||
|
Dave Hansen <dave.hansen@linux.intel.com>,
|
||
|
Hillf Danton <hdanton@sina.com>, Jens Axboe <axboe@kernel.dk>,
|
||
|
Johannes Weiner <hannes@cmpxchg.org>,
|
||
|
Jonathan Corbet <corbet@lwn.net>,
|
||
|
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
|
||
|
Matthew Wilcox <willy@infradead.org>,
|
||
|
Mel Gorman <mgorman@suse.de>,
|
||
|
Miaohe Lin <linmiaohe@huawei.com>,
|
||
|
Michael Larabel <michael@michaellarabel.com>,
|
||
|
Michal Hocko <mhocko@suse.com>,
|
||
|
Michel Lespinasse <michel@lespinasse.org>,
|
||
|
Rik van Riel <riel@surriel.com>,
|
||
|
Roman Gushchin <guro@fb.com>,
|
||
|
Rong Chen <rong.a.chen@intel.com>,
|
||
|
SeongJae Park <sjpark@amazon.de>,
|
||
|
Tim Chen <tim.c.chen@linux.intel.com>,
|
||
|
Vlastimil Babka <vbabka@suse.cz>,
|
||
|
Yang Shi <shy828301@gmail.com>,
|
||
|
Ying Huang <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
|
||
|
linux-kernel@vger.kernel.org, lkp@lists.01.org,
|
||
|
page-reclaim@google.com, Yu Zhao <yuzhao@google.com>
|
||
|
Content-Type: text/plain; charset="UTF-8"
|
||
|
Precedence: bulk
|
||
|
List-ID: <linux-kernel.vger.kernel.org>
|
||
|
X-Mailing-List: linux-kernel@vger.kernel.org
|
||
|
Archived-At: <https://lore.kernel.org/lkml/20210413065633.2782273-8-yuzhao@google.com/>
|
||
|
List-Archive: <https://lore.kernel.org/lkml/>
|
||
|
List-Post: <mailto:linux-kernel@vger.kernel.org>
|
||
|
|
||
|
Heuristics that determine scan balance between anon and file LRUs are
|
||
|
rather independent. Move them into a separate function to improve
|
||
|
readability.
|
||
|
|
||
|
Signed-off-by: Yu Zhao <yuzhao@google.com>
|
||
|
---
|
||
|
mm/vmscan.c | 186 +++++++++++++++++++++++++++-------------------------
|
||
|
1 file changed, 98 insertions(+), 88 deletions(-)
|
||
|
|
||
|
diff --git a/mm/vmscan.c b/mm/vmscan.c
|
||
|
index 562e87cbd7a1..1a24d2e0a4cb 100644
|
||
|
--- a/mm/vmscan.c
|
||
|
+++ b/mm/vmscan.c
|
||
|
@@ -2224,6 +2224,103 @@ enum scan_balance {
|
||
|
SCAN_FILE,
|
||
|
};
|
||
|
|
||
|
+static void prepare_scan_count(pg_data_t *pgdat, struct scan_control *sc)
|
||
|
+{
|
||
|
+ unsigned long file;
|
||
|
+ struct lruvec *target_lruvec;
|
||
|
+
|
||
|
+ target_lruvec = mem_cgroup_lruvec(sc->target_mem_cgroup, pgdat);
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Determine the scan balance between anon and file LRUs.
|
||
|
+ */
|
||
|
+ spin_lock_irq(&target_lruvec->lru_lock);
|
||
|
+ sc->anon_cost = target_lruvec->anon_cost;
|
||
|
+ sc->file_cost = target_lruvec->file_cost;
|
||
|
+ spin_unlock_irq(&target_lruvec->lru_lock);
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Target desirable inactive:active list ratios for the anon
|
||
|
+ * and file LRU lists.
|
||
|
+ */
|
||
|
+ if (!sc->force_deactivate) {
|
||
|
+ unsigned long refaults;
|
||
|
+
|
||
|
+ refaults = lruvec_page_state(target_lruvec,
|
||
|
+ WORKINGSET_ACTIVATE_ANON);
|
||
|
+ if (refaults != target_lruvec->refaults[0] ||
|
||
|
+ inactive_is_low(target_lruvec, LRU_INACTIVE_ANON))
|
||
|
+ sc->may_deactivate |= DEACTIVATE_ANON;
|
||
|
+ else
|
||
|
+ sc->may_deactivate &= ~DEACTIVATE_ANON;
|
||
|
+
|
||
|
+ /*
|
||
|
+ * When refaults are being observed, it means a new
|
||
|
+ * workingset is being established. Deactivate to get
|
||
|
+ * rid of any stale active pages quickly.
|
||
|
+ */
|
||
|
+ refaults = lruvec_page_state(target_lruvec,
|
||
|
+ WORKINGSET_ACTIVATE_FILE);
|
||
|
+ if (refaults != target_lruvec->refaults[1] ||
|
||
|
+ inactive_is_low(target_lruvec, LRU_INACTIVE_FILE))
|
||
|
+ sc->may_deactivate |= DEACTIVATE_FILE;
|
||
|
+ else
|
||
|
+ sc->may_deactivate &= ~DEACTIVATE_FILE;
|
||
|
+ } else
|
||
|
+ sc->may_deactivate = DEACTIVATE_ANON | DEACTIVATE_FILE;
|
||
|
+
|
||
|
+ /*
|
||
|
+ * If we have plenty of inactive file pages that aren't
|
||
|
+ * thrashing, try to reclaim those first before touching
|
||
|
+ * anonymous pages.
|
||
|
+ */
|
||
|
+ file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE);
|
||
|
+ if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE))
|
||
|
+ sc->cache_trim_mode = 1;
|
||
|
+ else
|
||
|
+ sc->cache_trim_mode = 0;
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Prevent the reclaimer from falling into the cache trap: as
|
||
|
+ * cache pages start out inactive, every cache fault will tip
|
||
|
+ * the scan balance towards the file LRU. And as the file LRU
|
||
|
+ * shrinks, so does the window for rotation from references.
|
||
|
+ * This means we have a runaway feedback loop where a tiny
|
||
|
+ * thrashing file LRU becomes infinitely more attractive than
|
||
|
+ * anon pages. Try to detect this based on file LRU size.
|
||
|
+ */
|
||
|
+ if (!cgroup_reclaim(sc)) {
|
||
|
+ unsigned long total_high_wmark = 0;
|
||
|
+ unsigned long free, anon;
|
||
|
+ int z;
|
||
|
+
|
||
|
+ free = sum_zone_node_page_state(pgdat->node_id, NR_FREE_PAGES);
|
||
|
+ file = node_page_state(pgdat, NR_ACTIVE_FILE) +
|
||
|
+ node_page_state(pgdat, NR_INACTIVE_FILE);
|
||
|
+
|
||
|
+ for (z = 0; z < MAX_NR_ZONES; z++) {
|
||
|
+ struct zone *zone = &pgdat->node_zones[z];
|
||
|
+
|
||
|
+ if (!managed_zone(zone))
|
||
|
+ continue;
|
||
|
+
|
||
|
+ total_high_wmark += high_wmark_pages(zone);
|
||
|
+ }
|
||
|
+
|
||
|
+ /*
|
||
|
+ * Consider anon: if that's low too, this isn't a
|
||
|
+ * runaway file reclaim problem, but rather just
|
||
|
+ * extreme pressure. Reclaim as per usual then.
|
||
|
+ */
|
||
|
+ anon = node_page_state(pgdat, NR_INACTIVE_ANON);
|
||
|
+
|
||
|
+ sc->file_is_tiny =
|
||
|
+ file + free <= total_high_wmark &&
|
||
|
+ !(sc->may_deactivate & DEACTIVATE_ANON) &&
|
||
|
+ anon >> sc->priority;
|
||
|
+ }
|
||
|
+}
|
||
|
+
|
||
|
/*
|
||
|
* Determine how aggressively the anon and file LRU lists should be
|
||
|
* scanned. The relative value of each set of LRU lists is determined
|
||
|
@@ -2669,7 +2766,6 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
|
||
|
unsigned long nr_reclaimed, nr_scanned;
|
||
|
struct lruvec *target_lruvec;
|
||
|
bool reclaimable = false;
|
||
|
- unsigned long file;
|
||
|
|
||
|
target_lruvec = mem_cgroup_lruvec(sc->target_mem_cgroup, pgdat);
|
||
|
|
||
|
@@ -2679,93 +2775,7 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
|
||
|
nr_reclaimed = sc->nr_reclaimed;
|
||
|
nr_scanned = sc->nr_scanned;
|
||
|
|
||
|
- /*
|
||
|
- * Determine the scan balance between anon and file LRUs.
|
||
|
- */
|
||
|
- spin_lock_irq(&target_lruvec->lru_lock);
|
||
|
- sc->anon_cost = target_lruvec->anon_cost;
|
||
|
- sc->file_cost = target_lruvec->file_cost;
|
||
|
- spin_unlock_irq(&target_lruvec->lru_lock);
|
||
|
-
|
||
|
- /*
|
||
|
- * Target desirable inactive:active list ratios for the anon
|
||
|
- * and file LRU lists.
|
||
|
- */
|
||
|
- if (!sc->force_deactivate) {
|
||
|
- unsigned long refaults;
|
||
|
-
|
||
|
- refaults = lruvec_page_state(target_lruvec,
|
||
|
- WORKINGSET_ACTIVATE_ANON);
|
||
|
- if (refaults != target_lruvec->refaults[0] ||
|
||
|
- inactive_is_low(target_lruvec, LRU_INACTIVE_ANON))
|
||
|
- sc->may_deactivate |= DEACTIVATE_ANON;
|
||
|
- else
|
||
|
- sc->may_deactivate &= ~DEACTIVATE_ANON;
|
||
|
-
|
||
|
- /*
|
||
|
- * When refaults are being observed, it means a new
|
||
|
- * workingset is being established. Deactivate to get
|
||
|
- * rid of any stale active pages quickly.
|
||
|
- */
|
||
|
- refaults = lruvec_page_state(target_lruvec,
|
||
|
- WORKINGSET_ACTIVATE_FILE);
|
||
|
- if (refaults != target_lruvec->refaults[1] ||
|
||
|
- inactive_is_low(target_lruvec, LRU_INACTIVE_FILE))
|
||
|
- sc->may_deactivate |= DEACTIVATE_FILE;
|
||
|
- else
|
||
|
- sc->may_deactivate &= ~DEACTIVATE_FILE;
|
||
|
- } else
|
||
|
- sc->may_deactivate = DEACTIVATE_ANON | DEACTIVATE_FILE;
|
||
|
-
|
||
|
- /*
|
||
|
- * If we have plenty of inactive file pages that aren't
|
||
|
- * thrashing, try to reclaim those first before touching
|
||
|
- * anonymous pages.
|
||
|
- */
|
||
|
- file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE);
|
||
|
- if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE))
|
||
|
- sc->cache_trim_mode = 1;
|
||
|
- else
|
||
|
- sc->cache_trim_mode = 0;
|
||
|
-
|
||
|
- /*
|
||
|
- * Prevent the reclaimer from falling into the cache trap: as
|
||
|
- * cache pages start out inactive, every cache fault will tip
|
||
|
- * the scan balance towards the file LRU. And as the file LRU
|
||
|
- * shrinks, so does the window for rotation from references.
|
||
|
- * This means we have a runaway feedback loop where a tiny
|
||
|
- * thrashing file LRU becomes infinitely more attractive than
|
||
|
- * anon pages. Try to detect this based on file LRU size.
|
||
|
- */
|
||
|
- if (!cgroup_reclaim(sc)) {
|
||
|
- unsigned long total_high_wmark = 0;
|
||
|
- unsigned long free, anon;
|
||
|
- int z;
|
||
|
-
|
||
|
- free = sum_zone_node_page_state(pgdat->node_id, NR_FREE_PAGES);
|
||
|
- file = node_page_state(pgdat, NR_ACTIVE_FILE) +
|
||
|
- node_page_state(pgdat, NR_INACTIVE_FILE);
|
||
|
-
|
||
|
- for (z = 0; z < MAX_NR_ZONES; z++) {
|
||
|
- struct zone *zone = &pgdat->node_zones[z];
|
||
|
- if (!managed_zone(zone))
|
||
|
- continue;
|
||
|
-
|
||
|
- total_high_wmark += high_wmark_pages(zone);
|
||
|
- }
|
||
|
-
|
||
|
- /*
|
||
|
- * Consider anon: if that's low too, this isn't a
|
||
|
- * runaway file reclaim problem, but rather just
|
||
|
- * extreme pressure. Reclaim as per usual then.
|
||
|
- */
|
||
|
- anon = node_page_state(pgdat, NR_INACTIVE_ANON);
|
||
|
-
|
||
|
- sc->file_is_tiny =
|
||
|
- file + free <= total_high_wmark &&
|
||
|
- !(sc->may_deactivate & DEACTIVATE_ANON) &&
|
||
|
- anon >> sc->priority;
|
||
|
- }
|
||
|
+ prepare_scan_count(pgdat, sc);
|
||
|
|
||
|
shrink_node_memcgs(pgdat, sc);
|
||
|
|
||
|
--
|
||
|
2.31.1.295.g9ea45b61b8-goog
|
||
|
|
||
|
|